Procházet zdrojové kódy

Only compute commits in repo upload if we need to show a prompt

If the user has disabled a prompt, skip the two commands we use to
obtain the list of commits and the date of the branch.  These will
never be displayed and just waste the end-user's time.

Signed-off-by: Shawn O. Pearce <sop@google.com>
Shawn O. Pearce před 17 roky
rodič
revize
66bdd46871
1 změnil soubory, kde provedl 3 přidání a 2 odebrání
  1. 3 2
      subcmds/upload.py

+ 3 - 2
subcmds/upload.py

@@ -99,8 +99,6 @@ or in the .git/config within the project.  For example:
   def _SingleBranch(self, branch, people):
     project = branch.project
     name = branch.name
-    date = branch.date
-    list = branch.commits
     remote = project.GetBranch(name).remote
 
     key = 'review.%s.autoupload' % remote.review
@@ -110,6 +108,9 @@ or in the .git/config within the project.  For example:
       _die("upload blocked by %s = false" % key)
 
     if answer is None:
+      date = branch.date
+      list = branch.commits
+
       print 'Upload project %s/:' % project.relpath
       print '  branch %s (%2d commit%s, %s):' % (
                     name,