Просмотр исходного кода

upload: exit non-zero when preupload hooks fail

Bug: https://crbug.com/gerrit/13159
Change-Id: Id140b619242c841223c6bc5d4aa0c37a7ce0219d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/276294
Reviewed-by: Jonathan Nieder <jrn@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
Mike Frysinger 5 лет назад
Родитель
Сommit
80944b538d
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      subcmds/upload.py

+ 1 - 1
subcmds/upload.py

@@ -596,7 +596,7 @@ Gerrit Code Review:  https://www.gerritcodereview.com/
           print('\nWARNING: pre-upload hooks failed, but uploading anyways.',
           print('\nWARNING: pre-upload hooks failed, but uploading anyways.',
                 file=sys.stderr)
                 file=sys.stderr)
         else:
         else:
-          return
+          return 1
 
 
     if opt.reviewers:
     if opt.reviewers:
       reviewers = _SplitEmails(opt.reviewers)
       reviewers = _SplitEmails(opt.reviewers)