Răsfoiți Sursa

flake8: Suppress "F821 undefined name" inline for Python 2 names

All of the instances of this are related to Python 2 names that
don't exist in Python 3, and the warnings are raised when running
flake8 on Python 3.

All of these will go away once we completely remove support for
Python 2, so just suppress them inline. We don't globally suppress
the check so that we will still see legitimate errors if/when they
occur in new code.

Change-Id: Iccf955f50abfc9f83b371fc0af6cceb51037456f
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255039
Tested-by: David Pursehouse <dpursehouse@collab.net>
Reviewed-by: Mike Frysinger <vapier@google.com>
David Pursehouse 6 ani în urmă
părinte
comite
a46bf7dc2a
5 a modificat fișierele cu 6 adăugiri și 6 ștergeri
  1. 1 1
      main.py
  2. 2 2
      platform_utils_win32.py
  3. 1 1
      project.py
  4. 1 1
      subcmds/gitc_delete.py
  5. 1 1
      subcmds/upload.py

+ 1 - 1
main.py

@@ -69,7 +69,7 @@ from wrapper import WrapperPath, Wrapper
 from subcmds import all_commands
 
 if not is_python3():
-  input = raw_input
+  input = raw_input  # noqa: F821
 
 global_options = optparse.OptionParser(
     usage='repo [-p|--paginate|--no-pager] COMMAND [ARGS]',

+ 2 - 2
platform_utils_win32.py

@@ -219,8 +219,8 @@ def _preserve_encoding(source, target):
   if is_python3():
     return target
 
-  if isinstance(source, unicode):
-    return unicode(target)
+  if isinstance(source, unicode):  # noqa: F821
+    return unicode(target)  # noqa: F821
   return str(target)
 
 

+ 1 - 1
project.py

@@ -52,7 +52,7 @@ else:
   import urlparse
   urllib = imp.new_module('urllib')
   urllib.parse = urlparse
-  input = raw_input
+  input = raw_input  # noqa: F821
 
 
 def _lwrite(path, content):

+ 1 - 1
subcmds/gitc_delete.py

@@ -22,7 +22,7 @@ import platform_utils
 
 from pyversion import is_python3
 if not is_python3():
-  input = raw_input
+  input = raw_input  # noqa: F821
 
 
 class GitcDelete(Command, GitcClientCommand):

+ 1 - 1
subcmds/upload.py

@@ -27,7 +27,7 @@ from project import RepoHook
 
 from pyversion import is_python3
 if not is_python3():
-  input = raw_input
+  input = raw_input  # noqa: F821
 else:
   unicode = str