Просмотр исходного кода

forall.py: Close file after removing the stream

In order to remove the stream fileno() will be called on the filedescriptor.
If the file is already closed fileno() will raise an error and forall
will fail.

Bug: https://crbug.com/gerrit/12563
Change-Id: Ib7b895fe881c844e3eb3672b011fdcdbdae63024
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/262838
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Tested-by: Karsten Pfeiffer-Raddatz <raddatz.karsten@gmail.com>
Karsten Pfeiffer-Raddatz 5 лет назад
Родитель
Сommit
d086467012
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      subcmds/forall.py

+ 1 - 1
subcmds/forall.py

@@ -370,8 +370,8 @@ def DoWork(project, mirror, opt, cmd, shell, cnt, config):
       for s in in_ready:
       for s in in_ready:
         buf = s.read().decode()
         buf = s.read().decode()
         if not buf:
         if not buf:
-          s.close()
           s_in.remove(s)
           s_in.remove(s)
+          s.close()
           continue
           continue
 
 
         if not opt.verbose:
         if not opt.verbose: